[Backport 2.18] [Bug] Fixed ListIOCs number of findings cap. #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Fixed finding number returned by ListIOCs API capping at 10,000. Signed-off-by: AWSHurneyt <[email protected]> * Added integ test for fix. Signed-off-by: AWSHurneyt <[email protected]> * Removed extraneous query params. Signed-off-by: AWSHurneyt <[email protected]> * Added additional test case. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit d5c8f7a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
amsiglan,
AWSHurneyt,
getsaurabh02,
lezzago,
praveensameneni,
sbcd90,
eirsep,
jowg-amazon,
engechas,
goyamegh and
riysaxen-amzn
as code owners
AWSHurneyt
approved these changes
Oct 23, 2024
jowg-amazon
approved these changes
Oct 23, 2024
eirsep
approved these changes
Oct 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.18 #1381 +/- ##
============================================
+ Coverage 69.03% 69.18% +0.14%
+ Complexity 3609 3607 -2
============================================
Files 405 405
Lines 20102 20114 +12
Branches 2045 2045
============================================
+ Hits 13877 13915 +38
+ Misses 5205 5176 -29
- Partials 1020 1023 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d5c8f7a from #1373.